-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(api): Made events central to workspace #159
Conversation
PR Description updated to latest commit (cd2a853) |
PR Review
✨ Review tool usage guide:Overview:
With a configuration file, use the following template:
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
With a configuration file, use the following template:
See the improve usage page for a more comprehensive guide on using this tool. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## approval-and-event #159 +/- ##
=====================================================
Coverage ? 94.77%
=====================================================
Files ? 90
Lines ? 1991
Branches ? 394
=====================================================
Hits ? 1887
Misses ? 104
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
## [1.3.0](v1.2.0...v1.3.0) (2024-05-12) ### 🚀 Features * Add approval support ([#158](#158)) ([e09ae60](e09ae60)) * **api:** Add configuration live update support ([#181](#181)) ([f7d6684](f7d6684)) * **api:** Add feature to export data of a workspace ([#152](#152)) ([46833aa](46833aa)) * **api:** Add Integration support ([#203](#203)) ([f1ae87e](f1ae87e)) * **api:** Add note to [secure] and variable ([#151](#151)) ([2e62351](2e62351)) * **api:** Add OAuth redirection and polished authentication ([#212](#212)) ([d2968bc](d2968bc)) * **api:** Add support for storing and managing variables ([#149](#149)) ([963a8ae](963a8ae)) * **api:** Added GitLab OAuth ([#188](#188)) ([4d3bbe4](4d3bbe4)) * **api:** Added validation for reason field ([#190](#190)) ([90b8ff2](90b8ff2)) * **api:** Create default workspace on user's creation ([#182](#182)) ([3dc0c4c](3dc0c4c)) * **api:** Reading `port` Dynamically ([#170](#170)) ([fd46e3e](fd46e3e)) * **auth:** Add Google OAuth ([#156](#156)) ([cf387ea](cf387ea)) * **web:** Added waitlist ([#168](#168)) ([1084c77](1084c77)) * **web:** Landing revamp ([#165](#165)) ([0bc723b](0bc723b)) ### 🐛 Bug Fixes * **web:** alignment issue in “Collaboration made easy” section ([#178](#178)) ([df5ca75](df5ca75)) * **workspace:** delete duplicate tailwind config ([99d922a](99d922a)) ### 📚 Documentation * add contributor list ([f37569a](f37569a)) * Add integration docs ([#204](#204)) ([406ddb7](406ddb7)) * Added integration docs to gitbook summary ([ab37530](ab37530)) * **api:** Add swagger docs of API key controller ([#167](#167)) ([2910476](2910476)) * **api:** Add swagger docs of User Controller ([#166](#166)) ([fd59522](fd59522)) * fix typo in environment-variables.md ([#163](#163)) ([48294c9](48294c9)) * Remove supabase from docs ([#169](#169)) ([eddbce8](eddbce8)) * **setup:** replace NX with Turbo in setup instructions ([#175](#175)) ([af8a460](af8a460)) * Update README.md ([b59f16b](b59f16b)) * Update running-the-api.md ([177dbbf](177dbbf)) * Update running-the-api.md ([#193](#193)) ([3d5bcac](3d5bcac)) ### 🔧 Miscellaneous Chores * Added lockfile ([60a3b9b](60a3b9b)) * Added lockfile ([6bb512c](6bb512c)) * **api:** Added type inference and runtime validation to `process.env` ([#200](#200)) ([249e07d](249e07d)) * **api:** Fixed prisma script env errors ([#209](#209)) ([8762354](8762354)) * **API:** Refactor authority check functions in API ([#189](#189)) ([e9d710d](e9d710d)) * **api:** Refactor user e2e tests ([b38d45a](b38d45a)) * **ci:** Disabled api stage release ([97877c4](97877c4)) * **ci:** Update stage deployment config ([868a6a1](868a6a1)) * **codecov:** update api-e2e project coverage ([1e90d7e](1e90d7e)) * **dockerfile:** Fixed web dockerfile ([6134bb2](6134bb2)) * **docker:** Optimized web Dockerfile to reduct image size ([#173](#173)) ([444286a](444286a)) * **release:** Downgraded package version ([c173fee](c173fee)) * **release:** Fix failing release ([#213](#213)) ([40f64f3](40f64f3)) * **release:** Install pnpm ([1081bea](1081bea)) * **release:** Updated release commit ([b8958e7](b8958e7)) * **release:** Updated release commit ([e270eb8](e270eb8)) * Update deprecated husky Install command ([#202](#202)) ([e61102c](e61102c)) * Upgrade @million/lint from 0.0.66 to 0.0.73 ([#172](#172)) ([dd43ed9](dd43ed9)) * **web:** Updated fly memory config ([4debc66](4debc66)) ### 🔨 Code Refactoring * **api:** Made events central to workspace ([#159](#159)) ([9bc00ae](9bc00ae)) * **api:** Migrated to cookie based authentication ([#206](#206)) ([ad6911f](ad6911f)) * **monorepo:** Migrate from nx to turbo ([#153](#153)) ([88b4b00](88b4b00))
Type
enhancement
Description
EventService
directly, improving test reliability.Changes walkthrough
14 files
event.e2e.spec.ts
Refactor Event E2E Tests and Add New Test Cases
apps/api/src/event/event.e2e.spec.ts
of HTTP requests.
workspace creation, project creation, and more.
workspace.e2e.spec.ts
Refactor Workspace Controller Tests and Add Event Assertions
apps/api/src/workspace/workspace.e2e.spec.ts
EventService
for fetchingevents.
role events.
project.e2e.spec.ts
Refactor Project Controller Tests with Event Assertions
apps/api/src/project/project.e2e.spec.ts
EventService
for eventassertions.
secret.e2e.spec.ts
Refactor Secret Controller Tests and Add Event Assertions
apps/api/src/secret/secret.e2e.spec.ts
EventService
.approval.e2e.spec.ts
Refactor Approval Controller Tests with Event Assertions
apps/api/src/approval/approval.e2e.spec.ts
EventService
.events.
variable.e2e.spec.ts
Refactor Variable Controller Tests and Add Event Assertions
apps/api/src/variable/variable.e2e.spec.ts
EventService
.workspace.service.ts
Ensure Event Creation in Workspace Service Methods
apps/api/src/workspace/service/workspace.service.ts
WorkspaceService
methods to awaitcreateEvent
calls, ensuringevents are created as part of the transaction.
environment.e2e.spec.ts
Refactor Environment Controller Tests with Event Assertions
apps/api/src/environment/environment.e2e.spec.ts
EventService
.event.service.ts
Refactor Event Service for Simplified Event Fetching
apps/api/src/event/service/event.service.ts
EventService
to simplify event fetching logic and supportfiltering by source.
workspace-role.e2e.spec.ts
Refactor Workspace Role Controller Tests with Event Assertions
apps/api/src/workspace-role/workspace-role.e2e.spec.ts
EventService
.create-event.ts
Simplify Event Creation with Direct Model Field Usage
apps/api/src/common/create-event.ts
createEvent
function to directly use new event model fields,simplifying the event creation process.
schema.prisma
Update Prisma Schema for Event Model Refactoring
apps/api/src/prisma/schema.prisma
removing unused relations and adding new fields.
migration.sql
Database Migration for Event Model Refactoring
apps/api/src/prisma/migrations/20240308054256_refactor_event/migration.sql
migration.sql
Final Database Migration Adjustments for Event Model
apps/api/src/prisma/migrations/20240308060811_/migration.sql
model.